fix missing check for multiline highlighting #2392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
reviewed
Jan 10, 2024
Comment on lines
+823
to
+824
| if multiline and not userprefs().show_multiline_document_highlights: | ||
| continue |
There was a problem hiding this comment.
I don't remember exactly how all of this works but shouldn't the existing same check above prevent those from being added to kind2regions in the first place?
There was a problem hiding this comment.
You are right, yes, thanks, it seems I had an unrelated multiline preference set and wasn't working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
show_multiline_document_highlightsisfalseit shouldn't be highlighting regions that spawn multiple lines